Reuse session csrf token #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple tabs to be open at the same time, without compromising security. Now, the cookie includes both a hash and the token, separated by "|". This allows the token generator to extract the token from an existing csrf session cookie and reuse it.
psibean
reviewed
Aug 15, 2023
psibean
reviewed
Aug 15, 2023
|
So I've just had some additional thoughts:
|
|
I've pulled down your branch and made some changes on the branch: https://github.com/Psifi-Solutions/csrf-csrf/tree/reuse-session-csrf-token You may be able to cherry-pick the commit: b24f941 My plan is for this to be a major update given the changes, thus I am also setting the default of overwrite to false - this way it mimics the Additionally, in another PR after this one, I'll make another breaking change which will finally switch the order of response and request params for |
psibean
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse token from existing session cookie.
This enables multitab support by not overwriting existing csrf cookies.
Functionality can be toggled with the param 'overwrite', which defaults to true (reusability of tokens is disabled by default).